Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the dates to null values on delete to handle the model state error #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jithendraprasad9999
Copy link
Contributor

@jithendraprasad9999 jithendraprasad9999 commented Nov 20, 2023

Resolves #433
Type: bugfix

Issue

Not able to delete the Product Tier Price when we assign the start date end time.

Solution

Issue is when we try to delete the Product Tier Price item with start time and end time it is , start time and end is going as GMT time and we are facing the model state error . So avoid that when we delete the item setting the start and end date to null.

Breaking changes

No

Testing

  1. Navigate to admin panel.
  2. Choose products from catalog menu and then pick any product go to prices tab and create a tire price with start and end time.
  3. Once creation of product price is done , we can delete the tire price item without any issue.

@jithendraprasad9999 jithendraprasad9999 changed the title Settign the dates to null values on delete to handle the model state error Setting the dates to null values on delete to handle the model state error Nov 20, 2023
@KrzysztofPajak
Copy link
Member

@jithendraprasad9999 Thanks for PR, I think we should find other solution.
The best way will be send request with data model with properties: productId and TierPriceId.

@jithendraprasad9999
Copy link
Contributor Author

@jithendraprasad9999 Thanks for PR, I think we should find other solution. The best way will be send request with data model with properties: productId and TierPriceId.

Sure @KrzysztofPajak i will update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Tier price cannot be deleted once start date and end date is associated
2 participants