refactor: move to deno 2.0 and refactor whole project to new approaches
#235
Conversation
Satont
changed the title
2.0 and refactor whole project to new features2.0 and refactor whole project to new approaches
Satont
changed the title
2.0 and refactor whole project to new approaches2.0 and refactor whole project to new approaches
it gives opportunity to not depend on external dependencies for storage, and support both `denodrivers/mongo` and `npm:mongodb`
Satont
changed the title
2.0 and refactor whole project to new approaches2.0 and refactor whole project to new approaches
[skip ci]
|
I have not forgotten this but I had too many other things to do, sorry |
KnorpelSenf
left a comment
KnorpelSenf
left a comment
There was a problem hiding this comment.
There are already many breaking changes. What are your thoughts on making all storage adapters consistent? Some are just a simple function, some require a class to the instantiated, but it's not obvious when to use what. Have you considered aligning this (make everything a function or everything a class)?
Also, it seems like formatting is configured for the entire workspace but not applied correctly in each project. Am I missing something?
| { | ||
| "deno.enable": true | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file is no longer needed with a top-level deno.json. The extension enables itself automatically nowadays.
| "useTabs": false, | ||
| "lineWidth": 100, | ||
| "indentWidth": 2, | ||
| "semiColons": true, | ||
| "singleQuote": true, | ||
| "proseWrap": "preserve", |
There was a problem hiding this comment.
Some are the default values so you might want to skip them.
| "useTabs": false, | |
| "lineWidth": 100, | |
| "indentWidth": 2, | |
| "semiColons": true, | |
| "singleQuote": true, | |
| "proseWrap": "preserve", | |
| "lineWidth": 100, | |
| "singleQuote": true, | |
| "proseWrap": "preserve", |
| "prettier": "^3.2.5", | ||
| "rimraf": "^5.0.5", | ||
| "tsx": "^4.7.1", |
| > [!NOTE] | ||
| > All tests for Deno should be placed in `packages/*/__tests__/deno` directory. | ||
| All testing processed via github actions, because it depends on `mongodb` and `postgres` services. Maybe layter we'll add docker tests locally. |
There was a problem hiding this comment.
| All testing processed via github actions, because it depends on `mongodb` and `postgres` services. Maybe layter we'll add docker tests locally. | |
| All testing processed via github actions, because it depends on `mongodb` and `postgres` services. | |
| Maybe later we'll add docker tests locally. |
| "test:deno": "echo \"Error: no tests found\"", | ||
| "prebuild": "rimraf dist", | ||
| "build": "deno2node tsconfig.cjs.json && deno2node tsconfig.esm.json && pnpm postbuild", | ||
| "build": "tsc -p tsconfig.cjs.json && tsc -p tsconfig.esm.json && pnpm postbuild", |
There was a problem hiding this comment.
I assume this is just for testing? Am I right that you would migrate to JSR and then skip the whole build process for publishing?
| "exports": "./src/mod.ts", | ||
| "version": "2.4.2", | ||
| "tasks": { | ||
| "test": "deno test --allow-import --allow-write --no-check --allow-read --unstable ./__tests__/deno/deno.ts" |
There was a problem hiding this comment.
I think --unstable was deprecated
| "free" | ||
| ], | ||
| "gitHead": "a7758c4f957f103a14832088c6858d693c444576" | ||
| "gitHead": "a7758c4f957f103a14832088c6858d693c444576", |
| @@ -1,78 +1,71 @@ | |||
| import test from 'node:test'; | |||
| import test, {} from 'node:test'; | |||
2 participants
Thats PR was created to rewrite existing code to new approaches.
Goals of this pr:
This will give us opportunity to release packages separately each other, and keep versions different.
node-fetchin packages, because it's available in nodejs as globalnode:*packages whereever is possible, to simplify writing and updating code without need to support both global runtime api's.denosupport forpockebase, since we doing only type import inside storage, and all interactions done viafetchcalls.