feat: add filter query for link_preview_options

[SpEcHiDe]

Based on the message_thread

Please let me know if this is expected approach.

[KnorpelSenf]

Nice, did you test this locally? Does it work as expected?

[SpEcHiDe]

steps i did to test locally:

git clone https://github.com/spechide/grammY
git checkout patch-1
npm install
npm run backport
deno task bundle-web

I was not able to test the link_preview_options:is_disabled scenario. Apart from that I was not able to find any issues in the above code.

but by testing below code, I found one issue,

const privateComposer = composer.chatType("private");

privateComposer.on("::url", async ctx => {
    console.log(ctx.update);
    
    const urls = ctx.entities(["url"]);
    console.log(urls);  // 
});

by testing with the below message.

The ctx.entities would not be able to obtain the url yet. Should it be able to do it, or not? 🤔

Can you let me know what are the expectations?

[KnorpelSenf]

The filter query ::url and ctx.entities both operate on the message entities. They are not related to the link preview in any way, so it is correct that they do not appear there.

[KnorpelSenf]

LGTM.

What needs to be done to move this out of draft state and get this ready to be merged?

[SpEcHiDe]

The filter query ::url and ctx.entities both operate on the message entities. They are not related to the link preview in any way, so it is correct that they do not appear there.

Ok,

What about the ::is_disabled thing? Apparently, if is_disabled is used to sendMessage then the Message object does not contain link_preview_options key. OR, maybe i am not able to test correctly.

[KnorpelSenf]

That's a great catch. I think it makes no sense to filter for is_disabled actually. It is already possible to filter for

bot.on("::url").drop(Context.has.filterQuery(":link_preview_options"))

which effectively only gives you messages URL entities but without link preview.

[KnorpelSenf]

@all-contributors add @SpEcHiDe for idea and code and test

[allcontributors]

@KnorpelSenf

I've put up a pull request to add @SpEcHiDe! 🎉