Fix unexpected behavior of Lens.withDefault #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks #17
The issue is that
Lens.withDefault
with unexpectedly use anundefined
value in place of a value passed into aLens.set
when it is equal to the default value provided.It makes sense, as it is more lawful (in lens laws terms) to remove a value when set to default. Although technically, the current implementation is not lawful either, because
{ a: 5, b: undefined }
is not strictly equal to{ a: 5 }
.I see these options:
Lens.withDefault
to actually modify the data structure even when set to a default value.Lens.withDefault
as it is and implement a separate lens with this new behavior.Bonus option: if we decide to keep current
Lens.withDefault
, fix it to be truly lawful.