Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): adjust dependencies required for grails 7 #395

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Oct 10, 2024

These changes are currently required to start a grails 7 web project.

The graal-sdk dependency will be handled as follows: bertramdev/asset-pipeline#352 (comment)

After removing the asset-pipeline Gradle plugin from buildSrc/build.gradle and setting.gradle and defining it in one location build.gradle, the graal-sdk dependency is no longer needed.

plugins {
     id "com.bertramlabs.asset-pipeline" version "5.0.1"
}

The larger consolidation of buildSrc, settings.gradle and build.gradle will occur on #347

Copy link
Contributor

@codeconsole codeconsole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need that dependency to start?

@jamesfredley jamesfredley changed the title add dependencies required for grails 7 web project to start Grails 7: adjust dependencies required for grails 7 web project to start Oct 11, 2024
…e plugin in build.gradle only

implementation("com.bertramlabs.plugins:asset-pipeline-gradle:5.0.1") in buildSrc/build.gradle was requiring the extra graal-sdk dependency
@jamesfredley jamesfredley self-assigned this Oct 11, 2024
@jamesfredley jamesfredley changed the title Grails 7: adjust dependencies required for grails 7 web project to start fix(deps): adjust dependencies required for grails 7 web project to start Oct 11, 2024
@jamesfredley jamesfredley changed the title fix(deps): adjust dependencies required for grails 7 web project to start fix(deps): adjust dependencies required for grails 7 Oct 11, 2024
@jamesfredley jamesfredley merged commit 514e2e7 into 7.0.x Oct 11, 2024
10 checks passed
@jamesfredley jamesfredley deleted the add-missing-grails-7-dependencies branch October 11, 2024 21:26
@codeconsole
Copy link
Contributor

codeconsole commented Oct 11, 2024

I am not sure grails-plugin-sitemesh3 should be added as a dependency. It should be resolved as a transitive of another dependency

@jamesfredley
Copy link
Contributor Author

Once that is in place, we will remove it here.

7.0.0-SNAPSHOT is currently an option on start.grails.org and this enables the generated application to start, for now.

@codeconsole
Copy link
Contributor

#399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants