Fix docu for tempo 2.7 #4572
Open
Fix docu for tempo 2.7 #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connections to Tempo running in a Docker container
suikast42
requested review from
knylander-grafana,
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
|
|
joe-elliott
reviewed
Jan 17, 2025
| @@ -145,14 +145,20 @@ distributor: | |||
| otlp: | |||
| protocols: | |||
| grpc: | |||
| # connections to Tempo running in a Docker container | |||
There was a problem hiding this comment.
let's remove this line. i think it's confusing.
|
Thanks for updating the docs! I'm happy to approve the PR once Joe's comment has been addressed. |
| http: | ||
| # connections to Tempo running in a Docker container |
There was a problem hiding this comment.
@joe-elliott Should this line also be removed, per your comment under gRPC?
Corrected this to sentence case, unless we need to remove the line.
Suggested change
| # connections to Tempo running in a Docker container | |
| # Connections to Tempo running in a Docker container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connections to Tempo running in a Docker container
See: #4567 (comment)
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]