MQE: Add support to disable functions+aggregations by name #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
force-pushed
the
jhesketh/mqe-function-flags
branch
from
8646304 to
28b5513
Compare
charleskorn
reviewed
Jan 10, 2025
pkg/streamingpromql/query.go
Outdated
Comment on lines
319
to
320
| if e.Func.Name == fName { | ||
| return nil, compat.NewNotSupportedError(fmt.Sprintf("'%s' function is disabled", e.Func.Name)) |
There was a problem hiding this comment.
In all other cases, we don't differentiate between a feature being unsupported entirely and a feature being disabled by a feature flag:
Suggested change
| if e.Func.Name == fName { | |
| return nil, compat.NewNotSupportedError(fmt.Sprintf("'%s' function is disabled", e.Func.Name)) | |
| if e.Func.Name == fName { | |
| return nil, compat.NewNotSupportedError(fmt.Sprintf("'%s' function", e.Func.Name)) |
There was a problem hiding this comment.
I feel like this is a little more explicitly disabled so the log line is helpful
There was a problem hiding this comment.
Not sure I follow sorry - isn't it just as explicit as any other feature disabled with a feature flag?
There was a problem hiding this comment.
The others are "enable" which default to true. This explicitly disables something, which is useful to know in the logs imo.
tacole02
approved these changes
Jan 10, 2025
charleskorn
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10067