Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make generate-otlp: check that tools are installed #10285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colega
Copy link
Contributor

@colega colega commented Dec 19, 2024

What this PR does

Saves some time to the next developer who has to run make generate-otlp and isn't familiar with the tools required.

@colega colega requested a review from a team as a code owner December 19, 2024 13:20
# Use GNU sed on MacOS falling back to `sed` everywhere else
SED=sed
SED="sed"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: making shellcheck happy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants