feat(ruler): add flags for the query frontend retries #10259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
force-pushed
the
julienduchesne/ruler-retries
branch
from
493f5d9 to
e89f6db
Compare
Currently, Mimir is hardcoded at 3 retries and 100ms as a minimum retry time. Could be useful to configure this
julienduchesne
force-pushed
the
julienduchesne/ruler-retries
branch
from
e89f6db to
fb55d8e
Compare
|
Should the config flags be experimental for now? |
The new flags expose the existing retry config which is already enabled for everyone using the query frontend, which isn't an experimental feature from what I can see. It doesn't seem like they should be experimental, unless I'm misunderstanding 🤔. |
tacole02
approved these changes
Dec 17, 2024
| @@ -2987,6 +2987,12 @@ Usage of ./cmd/mimir/mimir: | |||
| Override the default minimum TLS version. Allowed values: VersionTLS10, VersionTLS11, VersionTLS12, VersionTLS13 | |||
| -ruler.query-frontend.grpc-client-config.tls-server-name string | |||
| Override the expected name on the server certificate. | |||
| -ruler.query-frontend.max-retries int | |||
| [experimental] Maximum number of retries for a single request. (default 3) | |||
There was a problem hiding this comment.
this is actually max attempts, right? So it includes the first try. That's my understanding from reading the dskit code. I think we should clarify the CLI flag then.
dimitarvdimitrov
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Mimir is hardcoded at 3 retries and 100ms as a minimum retry time. Could be useful to configure this
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.