Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loki-mixin): Use valid RFC 1123 object names #16287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adinhodovic
Copy link
Contributor

@adinhodovic adinhodovic commented Feb 14, 2025

What this PR does / why we need it:

Fixes the loki-mixin to use valid object names. Getting issues when applying this through ArgoCD.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Sorry, something went wrong.

@trevorwhitney
Copy link
Collaborator

Would you mind filing an issue with an example of how this is breaking in ArgoCD for you, and maybe pointing to relevant section in the RFC 1123 spec? I wasn't aware in naming conventions in RFC 1123 beyond hostnames. I'm not necessarily against this change, just want to make sure I understand the motivation. Thanks!

@adinhodovic
Copy link
Contributor Author

adinhodovic commented Feb 14, 2025

Would you mind filing an issue with an example of how this is breaking in ArgoCD for you, and maybe pointing to relevant section in the RFC 1123 spec? I wasn't aware in naming conventions in RFC 1123 beyond hostnames. I'm not necessarily against this change, just want to make sure I understand the motivation. Thanks!

These files become k8s configmaps and u cant have underscores in those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants