chore: Replace image names with variable names in Makefile #15175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <[email protected]>
salvacorts
approved these changes
Nov 28, 2024
| @@ -1,5 +1,10 @@ | |||
| # Loki Project Makefile | |||
| # ______ ____ __ __ _ | |||
| ifeq ($(CI), true) | ||
| ifeq ($(CI),true) | ||
| # ensure buildx is set up | ||
| _ := $(shell ./tools/ensure-buildx-builder.sh) |
There was a problem hiding this comment.
nit: ci stages that don't run any of the build image targets would still call this
There was a problem hiding this comment.
@ashwanthgoli Do you know why the script only ran as dependency of the build-image target? Is it problematic that it runs every time in CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use existing variables for image names in the make targets,
e.g. replace
$(IMAGE_PREFIX)/loki:$(IMAGE_TAG)with$(LOKI_IMAGE)