Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add clarifications for ruler remote write config options #15167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avanish-vaghela
Copy link

What this PR does / why we need it:

The update provides better understanding of the ruler remote write config behaviour. If a user specifies an 'X-Scope-OrgID' header under the 'headers' section of RemoteWriteConfig, the config parser silently drops this. This is not currently clear to the user and can lead to confusion. This update aims to clarify this.

It also adds clarification about what tenant ID value will be added to the 'X-Scope-OrgID' header in the remote write request if 'add_org_id_header' config parameter is set to 'true'.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
None

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@avanish-vaghela avanish-vaghela requested a review from a team as a code owner November 27, 2024 21:16
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 27, 2024
@avanish-vaghela avanish-vaghela force-pushed the update-ruler-remote-write-config-docs branch from c424310 to 9abd88d Compare November 27, 2024 21:18
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration docs are generated from code, specifically from the ruler config in pkg/ruler/config.go. You need to change the wording there and run make docs to generate the documentation.

@avanish-vaghela avanish-vaghela force-pushed the update-ruler-remote-write-config-docs branch from 9abd88d to 5892326 Compare November 29, 2024 15:41
@avanish-vaghela
Copy link
Author

I have the updated the comments in the code.

@avanish-vaghela avanish-vaghela force-pushed the update-ruler-remote-write-config-docs branch from 5892326 to 9d2c66d Compare November 29, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants