Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning around using logstash plugin for new deployments (backport release-3.2.x) #15137

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 26, 2024

Backport 716d54e from #14058


What this PR does / why we need it:

Over the years we have really grown to loathe the logstash plugin for the reasons described in the text of this PR. We aren't deprecating or removing it yet but really want to discourage its use for any new deployments.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…14058)

Signed-off-by: Edward Welch <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 716d54e)
@loki-gh-app loki-gh-app bot added the backport label Nov 26, 2024
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 26, 2024 20:49
@loki-gh-app loki-gh-app bot added size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Nov 26, 2024
@loki-gh-app loki-gh-app bot requested a review from JStickler November 26, 2024 20:49
@JStickler JStickler merged commit b166028 into release-3.2.x Nov 26, 2024
60 of 63 checks passed
@JStickler JStickler deleted the backport-14058-to-release-3.2.x branch November 26, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants