Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added video and fixed config value (backport release-3.3.x) #15129

Merged
merged 1 commit into from
Nov 26, 2024
Merged

docs: Added video and fixed config value (backport release-3.3.x) #15129

merged 1 commit into from
Nov 26, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 26, 2024

Backport 06fff99 from #14813

What this PR does / why we need it:
Added video + fixed config value.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 26, 2024 17:47
@loki-gh-app loki-gh-app bot added backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Nov 26, 2024
@loki-gh-app loki-gh-app bot requested a review from chaudum November 26, 2024 17:47
@JStickler JStickler merged commit 10ffedb into release-3.3.x Nov 26, 2024
66 checks passed
@JStickler JStickler deleted the backport-14813-to-release-3.3.x branch November 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@chaudum chaudum Awaiting requested review from chaudum

Assignees
No one assigned
Labels
backport size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JStickler @Jayclifford345