Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove target lag and keep just maximum lag #15120

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 26, 2024

What this PR does / why we need it:

This commit is an experiment to see if we can remove target lag and just keep maximum lag. The goal here is to simplify the code and make the catch up feature easier to reason about. However, if we find that this causes stale reads, we can add it back.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 26, 2024
@grobinson-grafana grobinson-grafana changed the title feature: remove target lag and keep just maximum lag feat: remove target lag and keep just maximum lag Nov 26, 2024
@grobinson-grafana grobinson-grafana force-pushed the grobinson/remove-target-lag branch 5 times, most recently from 26c0282 to eecb81d Compare November 26, 2024 16:52
@grobinson-grafana grobinson-grafana marked this pull request as ready for review November 26, 2024 16:52
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 26, 2024 16:52
This commit is an experiment to see if we can remove target lag and
just keep maximum lag. The goal here is to simplify the code and
make the catch up feature easier to reason about. However, if we find
that this causes stale reads, we can add it back.
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana merged commit 12386a2 into main Nov 27, 2024
59 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/remove-target-lag branch November 27, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants