Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Blooms docs #15081

Merged
merged 2 commits into from
Nov 22, 2024
Merged

docs: Update Blooms docs #15081

merged 2 commits into from
Nov 22, 2024

Conversation

stevendungan
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@stevendungan
remove admonition
dfcd93f 
remove instruction advising against extracting information that already exists in your log lines, since this is an intended use case of Bloom filters.
@stevendungan
Add cloud admonition
9f08f99 
Add admonition specifying Bloom filters are only available in Cloud to certain customers
@stevendungan stevendungan added size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories backport k227 labels Nov 22, 2024
@stevendungan stevendungan requested a review from a team as a code owner November 22, 2024 17:40
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

1 similar comment
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

JStickler
JStickler approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler changed the title Blooms docs docs: Update Blooms docs Nov 22, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 22, 2024

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 3aad529 into main Nov 22, 2024
69 checks passed
@JStickler JStickler deleted the blooms_docs branch November 22, 2024 17:48
loki-gh-app bot pushed a commit that referenced this pull request Nov 22, 2024
@stevendungan @grafana-delivery-bot
docs: Update Blooms docs (#15081)
9210305 
(cherry picked from commit 3aad529)
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendungan @JStickler