Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ifc from interface names #15072

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 22, 2024

Ths is a nit, but I think we should avoid using type information in the type definition, this commit renames ReaderIfc to Reader and Reader to StdReader.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

To avoid using type information in the type definition, this commit
renames ReaderIfc to Reader and Reader to StdReader.
@grobinson-grafana grobinson-grafana force-pushed the grobinson/remove-ifc-from-interface branch from d95aa4b to f3be3cf Compare November 22, 2024 13:26
@grobinson-grafana grobinson-grafana merged commit 3cc3db9 into main Nov 22, 2024
58 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/remove-ifc-from-interface branch November 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants