-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chunkv5): Chunk V5 structure, encoding and decoding #14674
Draft
shantanualsi
wants to merge
50
commits into
main
Choose a base branch
from
chunkv5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanualsi
changed the title
chunkv5
[feat]: Chunk V5 structure, encoding and decoding
Nov 4, 2024
shantanualsi
changed the title
[feat]: Chunk V5 structure, encoding and decoding
feat(chunkv5): Chunk V5 structure, encoding and decoding
Nov 4, 2024
shantanualsi
force-pushed
the
chunkv5
branch
from
November 13, 2024 11:21
9c57932
to
897d899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New Organized Chunk Format (V5)
Overview
This PR introduces a new chunk format (V5) for Loki that organizes log data into distinct sections: log lines, timestamps, and structured metadata. This organization enables more efficient querying by allowing selective decompression of only the required sections.
Changes
ChunkFormatV5
constantorganisedHeadBlock
for organizing data during writesorganizedBufferedIterator
for efficient reading of organized chunksCurrent Status
This PR focuses on the storage format implementation and core functionality. The following aspects will be addressed in subsequent PRs:
Ongoing work:
Performance Benchmarking
Migration Support
Design:
Refer
pkg/chunkenc/chunk-v5.md
in this PR for more documentationWhat this PR does / why we need it:
Which issue(s) this PR fixes:
https://github.com/grafana/loki-private/issues/1134
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR