Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix helm release #14501

Merged
merged 26 commits into from
Oct 16, 2024
Merged

ci: fix helm release #14501

merged 26 commits into from
Oct 16, 2024

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Oct 16, 2024 •
edited
Loading

What this PR does / why we need it:

Fixes the helm release to do a regular release (and not just a k release) every week.

Fixes #14373

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 16, 2024 14:43
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 16, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 16, 2024
@trevorwhitney trevorwhitney mentioned this pull request Oct 16, 2024
Closed
@trevorwhitney trevorwhitney merged commit 0446d63 into main Oct 16, 2024
62 of 63 checks passed
@trevorwhitney trevorwhitney deleted the fix-helm-release branch October 16, 2024 21:19
@trevorwhitney trevorwhitney mentioned this pull request Oct 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasslessParticle MasslessParticle MasslessParticle approved these changes

Assignees
No one assigned
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm release CI broken for 6.17
2 participants
@trevorwhitney @MasslessParticle