cleanup

grafana · Nov 18, 2024 · e279e79 · e279e79
1 parent 237eaa6
commit e279e79
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/pkg/kafka/partition/reader_refactor.go b/pkg/kafka/partition/reader_refactor.go
@@ -26,7 +26,6 @@ const (
 )
 
 type ReaderIfc interface {
-	Client() *kgo.Client
 	Topic() string
 	Partition() int32
 	ConsumerGroup() string
@@ -48,7 +47,7 @@ type refactoredReaderMetrics struct {
 	lastCommittedOffset prometheus.Gauge
 }
 
-func newRefactoredReaderMetrics(r prometheus.Registerer, partitionID int32) *refactoredReaderMetrics {
+func newRefactoredReaderMetrics(r prometheus.Registerer) *refactoredReaderMetrics {
 	return &refactoredReaderMetrics{
 		fetchWaitDuration: promauto.With(r).NewHistogram(prometheus.HistogramOpts{
 			Name:                        "loki_kafka_reader_fetch_wait_duration_seconds",
@@ -104,16 +103,11 @@ func NewRefactoredReader(
 		topic:         topic,
 		partitionID:   partitionID,
 		consumerGroup: consumerGroup,
-		metrics:       newRefactoredReaderMetrics(reg, partitionID),
+		metrics:       newRefactoredReaderMetrics(reg),
 		logger:        logger,
 	}
 }
 
-// Client returns the underlying Kafka client
-func (r *RefactoredReader) Client() *kgo.Client {
-	return r.client
-}
-
 // Topic returns the topic being read
 func (r *RefactoredReader) Topic() string {
 	return r.topic