Skip to content

Commit

Permalink
Remove last mentions of ifc
Browse files Browse the repository at this point in the history
  • Loading branch information
grobinson-grafana committed Nov 22, 2024
1 parent 3cc3db9 commit e13e0ff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions pkg/kafka/client/reader_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (

"github.com/go-kit/log"
"github.com/go-kit/log/level"
"github.com/pkg/errors"
"github.com/prometheus/client_golang/prometheus"
"github.com/twmb/franz-go/pkg/kadm"
"github.com/twmb/franz-go/pkg/kgo"
Expand All @@ -36,7 +35,7 @@ func NewReaderClient(kafkaCfg kafka.Config, metrics *kprom.Metrics, logger log.L
)
client, err := kgo.NewClient(opts...)
if err != nil {
return nil, errors.Wrap(err, "creating kafka client")
return nil, fmt.Errorf("creating kafka client: %w", err)
}
if kafkaCfg.AutoCreateTopicEnabled {
setDefaultNumberOfPartitionsForAutocreatedTopics(kafkaCfg, client, logger)
Expand Down
6 changes: 3 additions & 3 deletions pkg/kafka/partition/reader_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ func NewReaderService(
)

if err != nil {
return nil, errors.Wrap(err, "creating kafka reader")
return nil, fmt.Errorf("creating kafka reader: %w", err)
}

return newReaderServiceFromIfc(
return newReaderService(
ReaderConfig{
TargetConsumerLagAtStartup: kafkaCfg.TargetConsumerLagAtStartup,
MaxConsumerLagAtStartup: kafkaCfg.MaxConsumerLagAtStartup,
Expand All @@ -107,7 +107,7 @@ func NewReaderService(
), nil
}

func newReaderServiceFromIfc(
func newReaderService(
cfg ReaderConfig,
reader Reader,
consumerFactory ConsumerFactory,
Expand Down

0 comments on commit e13e0ff

Please sign in to comment.