Skip to content

Commit

Permalink
more linting
Browse files Browse the repository at this point in the history
  • Loading branch information
owen-d committed Nov 22, 2024
1 parent 1df3297 commit 7c475e5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/blockbuilder/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func (d *dummyPartitionController) HighestPartitionOffset(_ context.Context) (in
return d.highest, nil
}

func (d *dummyPartitionController) Commit(ctx context.Context, offset int64) error {
func (d *dummyPartitionController) Commit(_ context.Context, offset int64) error {
d.committed = offset
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/blockbuilder/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type kafkaConsumer struct {
decoder *kafka.Decoder
}

func (c *kafkaConsumer) Write(ctx context.Context, req *push.PushRequest) error {
func (c *kafkaConsumer) Write(_ context.Context, req *push.PushRequest) error {

Check warning on line 18 in pkg/blockbuilder/writer.go

View workflow job for this annotation

GitHub Actions / check / golangciLint

unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
return nil
}

func (c *kafkaConsumer) Commit(ctx context.Context) error {
func (c *kafkaConsumer) Commit(_ context.Context) error {
return nil
}

0 comments on commit 7c475e5

Please sign in to comment.