fix: incorrect error check in autoCommitLoop (#15149)

grafana · Nov 27, 2024 · 4b5925a · 4b5925a
1 parent 2eea546
commit 4b5925a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/kafka/partition/committer.go b/pkg/kafka/partition/committer.go
@@ -95,11 +95,13 @@ func (c *partitionCommitter) autoCommitLoop(ctx context.Context) {
 				continue
 			}
 
-			if err := c.Commit(ctx, currOffset); err == nil {
-				level.Error(c.logger).Log("msg", "failed to commit", "offset", currOffset)
-				c.lastCommittedOffset.Set(float64(currOffset))
-				previousOffset = currOffset
+			if err := c.Commit(ctx, currOffset); err != nil {
+				level.Error(c.logger).Log("msg", "failed to commit", "offset", currOffset, "err", err)
+				continue
 			}
+
+			c.lastCommittedOffset.Set(float64(currOffset))
+			previousOffset = currOffset
 		}
 	}
 }