Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison of folders, don't consider parents field when diffing #538

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix comparison of folders, don't consider parents field when diffing #538

merged 1 commit into from
Dec 9, 2024

Conversation

nresare
Copy link
Contributor

@nresare nresare commented Dec 4, 2024

closes #537

@nresare nresare requested a review from a team as a code owner December 4, 2024 21:26
@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@K-Phoen K-Phoen self-assigned this Dec 5, 2024
@K-Phoen
Copy link
Member

K-Phoen commented Dec 5, 2024

Looks good, thanks for the issue & PR :)

I'll merge this once the CLA is signed.

@nresare
Copy link
Contributor Author

nresare commented Dec 9, 2024

I have signed the CLA now, ping @K-Phoen

@K-Phoen K-Phoen merged commit a9a818a into grafana:main Dec 9, 2024
7 checks passed
@K-Phoen
Copy link
Member

K-Phoen commented Dec 9, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Phoen K-Phoen K-Phoen approved these changes

Assignees

@K-Phoen K-Phoen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: nested folder children are always considered changed by grr diff
3 participants
@nresare @CLAassistant @K-Phoen