Split proxy configuration out of resource handlers #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was starting to feel a bit overwhelmed by the amount of code/methods in resource handlers, which only increases for handlers that need to describe how to proxy resources for
grr serve
.In this PR, I suggest to split proxy configuration code out of resource handlers and into a dedicated file/struct.
This is purely a refactoring: no bug was fixed or feature changed/introduced.
As a next step, I would like the individual
ProxyConfigurator
structs to describe this configuration:grizzly/pkg/grizzly/server.go
Lines 102 to 148 in eca189d
It would allow to have this config close to the resource handler that requires it, instead of globally set by the server.