Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support previewing AlertRuleGroup resources in grr serve #526

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Nov 15, 2024

This PR adds support for previewing AlertRuleGroup resources in grr serve.

Here's how it looks:

Grizzly server home

Screenshot 2024-11-15 at 14-18-26 Grizzly

AlertRuleGroup page

Screenshot 2024-11-15 at 14-18-39 Grizzly

Note: AlertRuleGroup resources can NOT be persisted via the grizzly server (yet, this may be implemented later).

@K-Phoen K-Phoen requested a review from a team as a code owner November 15, 2024 11:17
@K-Phoen K-Phoen self-assigned this Nov 15, 2024
@K-Phoen K-Phoen changed the base branch from main to proxy-datasources November 15, 2024 11:18
@K-Phoen K-Phoen marked this pull request as draft November 15, 2024 11:18
@K-Phoen K-Phoen marked this pull request as ready for review November 15, 2024 13:19
@K-Phoen K-Phoen changed the title proxy alert rules Support previewing AlertRuleGroup resources in grr serve Nov 15, 2024
Base automatically changed from proxy-datasources to main November 26, 2024 13:36
@K-Phoen K-Phoen merged commit 049d02e into main Nov 26, 2024
7 checks passed
@K-Phoen K-Phoen deleted the proxy-alert-rules branch November 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants