Fix grr get of an AlertRuleGroup with UID containing dots
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokom
approved these changes
Nov 4, 2024
|
I want to do some more tests tomorrow, from this bit of code it looks like handler names can be composed of two parts (which surprises me). I feel like a bit more checks are required, in case I break something I'm just not aware of (that also wouldn't be covered by tests 😅) |
|
"this bit" above is needed for Synthetic Monitoring, IIRC, as a check didn't have a unique identifier - so we needed to use its name and type to make a unique identifier. |
|
Thanks for the tip :) I tested with SM checks and it seems to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516
Fixes the logic used by
grr getto split the Handler name from the rest of the UID.