Make livereloading of watched dashboards more reliable #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Phoen
commented
Oct 30, 2024
| @@ -289,7 +289,7 @@ func (s *Server) updateWatchedResource(name string) error { | |||
| } | |||
| resources, err = s.ParseBytes(b) | |||
| } else { | |||
| resources, err = s.ParseResources(s.ResourcePath) | |||
| resources, err = s.ParseResources(name) | |||
There was a problem hiding this comment.
This is a drive-by fix: let's parse the resource that changed instead of re-parsing all of them.
Instead of using Grafana's websocket to trigger a dashboard refresh, let's use a more crude approach and refresh the entire page. The server-side implementation of the livereload process is taken from https://github.com/gohugoio/hugo/tree/62567d38205a61134a6822d37a534520772419f1/livereload It has been adjusted to ensure that only dashboards that changed will be reloaded.
… modifications to it
K-Phoen
force-pushed
the
more-reliable-livereload
branch
from
d9d52ad to
cb4eceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Grafana's websocket to trigger a dashboard refresh, let's use a more crude approach and refresh the entire page.
The server-side implementation of the livereload process is taken from https://github.com/gohugoio/hugo/tree/62567d38205a61134a6822d37a534520772419f1/livereload
It has been adjusted to ensure that only dashboards that changed will be reloaded.