Add MIMIR_AUTH_TOKEN for self-hosted Mimir #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
spinillos
approved these changes
Oct 15, 2024
spinillos
reviewed
Oct 15, 2024
pkg/config/model.go
Outdated
| TenantID string `yaml:"tenant-id" mapstructure:"tenant-id"` | ||
| APIKey string `yaml:"api-key" mapstructure:"api-key"` | ||
| TLS MimirTLSConfig `yaml:"tls" mapstructure:"tls"` | ||
| AuthToken string `yaml:"auth-token" mapstructure:"auth-token""` |
There was a problem hiding this comment.
Suggested change
| AuthToken string `yaml:"auth-token" mapstructure:"auth-token""` | |
| AuthToken string `yaml:"auth-token" mapstructure:"auth-token"` |
There was a problem hiding this comment.
Not sure how that extra " slipped in there, good catch! Fixed this and resolved the other linter error
|
Looks like that you have a few linter errors. Update them and we could merge your PR. |
|
Tanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For self-hosted Mimir installations, an authenticating reverse proxy is typically required (https://grafana.com/docs/mimir/latest/manage/secure/authentication-and-authorization/#with-an-authenticating-reverse-proxy).
Implementations can choose any method to perform that authentication, but it's typically basic auth (which is already supported here), or a Bearer token in the Authorization header. This adds support for the latter.