Make the watch and watch script options behave more intuitively #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+184
to
+187
| _, err = s.ParseResources(s.ResourcePath) | ||
| if err != nil { | ||
| fmt.Print(err) | ||
| } |
There was a problem hiding this comment.
Here, you're parsing resources for all invocations. But, with a watchScript, surely the path(s) provided are just to things to watch. We don't want to be parsing my-dashboard.ts for example? That's why it doesn't parse when watchScript is set.
K-Phoen
force-pushed
the
issue-492/more-intuitive-watch
branch
from
4e62bdb to
d1e7a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #492
This PR makes
grr servebehave in a more intuitive manner when the-Sflag is used.With this change,
-S(watch script) implies-w(watch). Furthermore, the given resources path is no longer ignored when a watch script is given.