Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore secureJsonData field in Datasources when diff-ing #491

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Ignore secureJsonData field in Datasources when diff-ing #491

merged 1 commit into from
Sep 12, 2024

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Sep 11, 2024

Fixes #487

This issue was caused by two bugs:

  • the secureJsonData field in datasources wasn't ignored when calculating a diff
  • the diff was calculated using a representation of the local resource that was generated before it was modified by Unprepare()

@K-Phoen K-Phoen self-assigned this Sep 11, 2024
@K-Phoen K-Phoen requested a review from a team as a code owner September 11, 2024 15:25
@K-Phoen K-Phoen merged commit 2f503d9 into main Sep 12, 2024
7 checks passed
@K-Phoen K-Phoen deleted the fix/issue-487 branch September 12, 2024 10:31
@BrewTestBot BrewTestBot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmholmes malcolmholmes malcolmholmes approved these changes

Assignees

@K-Phoen K-Phoen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: datasources always report diff when using secureJsonData
2 participants
@K-Phoen @malcolmholmes