-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region to SM backend URL #420
Conversation
@@ -26,6 +26,7 @@ import ( | |||
*/ | |||
|
|||
const smBaseURL = "https://synthetic-monitoring-api.grafana.net" | |||
const smRegionURL = "https://synthetic-monitoring-api-%s.grafana.net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the same exceptions as here: https://github.com/grafana/terraform-provider-grafana/blob/main/internal/resources/cloud/resource_synthetic_monitoring_installation.go#L16-L22
Otherwise, if someone creates a stack in eu
, and tries to use Grizzly, it will fail. All new APIs (from new supported clusters) are being provisioned with the API URL you have here, so this will be fairly future-proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing that the list here is larger than the one set in TF provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probes, not API endpoints, right? A probe is the remote node that pings your host. They connect to an API for configuration. There will be far fewer API endpoints than probes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, these are the API endpoints for probes to connect to. We have lots of API endpoints (one per cluster)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two small comments
Related: #388
It allows to set the region for Synthetic Monitoring.