-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grizzly/actions/setup GitHub action #374
Conversation
f9e4134
to
543ac16
Compare
d821a99
to
df7ae72
Compare
df7ae72
to
06b223e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we could use a go install
composite action and avoid a lot of javascript here
Also, do we have somewhere we want to use this or is this for future use?
8676a0a
to
7e2ecb2
Compare
5d8aa04
to
c01f190
Compare
Running I wanted to ensure fast runtimes by downloading pre-compiled binaries instead, and taking advantage of GitHub action's "tools cache". That last part is why this action is written in Javascript. Unfortunately, I also just discovered that this cache isn't persistent across workflow runs :( (see actions/toolkit#58)
Nothing specific in mind, this PR is just me fooling around 😅 Even though it could be made slightly more useful by providing ways to setup Grizzly's configuration/contexts. Something like: - uses: grafana/grizzly/actions/setup@main
with:
version: 'v0.4.0'
context:
grafana.url: https://my-instance.grafana.net
grafana.token: ${{ secrets.GRAFANA_TOKEN }}
- run: grr diff ./resources Admittedly, this action isn't absolutely necessary to use grizzly in a github action. I just feel like we could provide it to remove some of the boilerplate necessary to set it up 🤷 WDYT? |
c01f190
to
f64e552
Compare
+1 please land this, i'd love it :) |
f64e552
to
32cdff8
Compare
32cdff8
to
a6eff79
Compare
plz land this xD |
+1 to landing this :) |
We released this GitHub action in its own repository: https://github.com/grafana/setup-grizzly |
This PR introduces a GitHub action that can be used to setup Grizzly in a job.
I'm thinking that having two github actions could be nice:
apply
command)Both these actions would make it easier to build automation on top of grizzly, in GitHub actions.
Open questions: