Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handlers #270

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Simplify handlers #270

merged 5 commits into from
Nov 24, 2023

Conversation

malcolmholmes
Copy link
Collaborator

Each handler currently has two files (three including tests), one for the handler itself, and another for utility functions that are package global.

This is daft. Why have this separation when everything relates to the handler itself.

This PR merges all the logic relating to a handler into a single file. In some situations, this could itself lead to further code reduction.

@malcolmholmes malcolmholmes requested a review from a team November 23, 2023 18:15
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming most of the moved code is the same. The extra level (functions outside of the handlers) didn't make much sense indeed when the handler has all it needs to do the API calls

@malcolmholmes malcolmholmes merged commit f629138 into master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants