Deprecate --directory/-d flag in favor of os.Stat #259
Conversation
| func Pull(resourcePath string, opts Opts) error { | ||
| log.Infof("Pulling resources from %s", resourcePath) | ||
| stat, err := os.Stat(resourcePath) | ||
| if err != nil { |
There was a problem hiding this comment.
It's probably good idea to omit ErrNotExist errors here, cause in Pull operations, the local directory might not exist, and can just be created. Right? Wdyt? @malcolmholmes
There was a problem hiding this comment.
pull requires a dir, no? In which case, sure it can make the dir.
There was a problem hiding this comment.
Yeah, agreed! I added a bunch of changes to handle that, as well as to test the expected behavior!
|
-d introduced a very different way of operating. Instead of parsing a single file, it processed a complete directory of files. This seemed like a big difference at the time justifying an argument to distinguish. I'm more than happy though with your observation that the flag is superfluous. I guess I would keep -d, confirm that, in that case the arg is a dir, and allow the situation without an argument to also accept a dir. |
I think that'd be the behavior with the current set of changes:
Sounds good? |
One of the few things that @undef1nd and I found a bit weird when starting to explore the Grizzly command-line interface is the need to specify the
--directory/-dflag to say that the<resource-path>is a directory, an even more confusing that it's mandatory for thegrr pullcommand.So, this is both:
os.Statinstead to determine whether the provided path<resource-path>is a directory or notNote that the suggestion here is to keep it, but as deprecated, just to avoid breaking changes straight away.
Thanks!