feat: added watchers for cm, secrets in datasource_controller #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vignesh-codes
requested review from
nissessenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin,
pb82 and
Baarsgaard
as code owners
|
|
Baarsgaard
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a GrafanaDatasource CR references secrets or configmaps through the
valuesFromfield, the operator will now automatically reconcile the datasource whenever those referenced resources change.Related Issue
Fixes #2142
What Changed
Note:
Should we add to add reconciler logic here too or in a separate PR? it says todo
grafana-operator/controllers/serviceaccount_controller.go
Line 829 in 37a6cfd
lemme know