Skip to content

Conversation

RaviTejaNalluri
Copy link

This is the issue that I worked for reviewers reference:#2143

This PR adds the Grafana resource UID to reconciliation error logs to improve troubleshooting in environments with multiple dashboards/datasources.

Changes Made:

Path: controllers/dashboard_controller.go:

  • Added uid to plugin error logs.
  • Prefixed applyErrors and applyHomeErrors with uid.
  • Included uid in the final aggregated “failed to apply to all instances” error.

Path: controllers/datasource_controller.go:

  • Compute uid via cr.CustomUIDOrUID().
  • Added uid to plugin error logs.
  • Prefixed applyErrors with uid.
  • Included uid in the final aggregated “failed to apply to all instances” error.

Testing: make all (lint/build/tests) passed locally.

Thank you. Do let me know if I need to change else where or if I need to make any other improvements.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ravi Teja Nalluri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nissessenap nissessenap disabled auto-merge September 2, 2025 04:30
@Baarsgaard Baarsgaard linked an issue Sep 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Uid to the error log when reconciling dashboards
2 participants