Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.ebpf: pass go_table_fallback arg #2587

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Conversation

korniltsev
Copy link
Contributor

PR Description

Add go_table_fallback arg to pyroscope.ebpf
A flag to enable symbol lookup in .sym / .dynsym sections when .gopclntab lookup failed. May be useful for cgo binaries.

Which issue(s) this PR fixes

https://raintank-corp.slack.com/archives/C03NCLB4GG7/p1738008990554889

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested review from a team and clayton-cornell as code owners January 31, 2025 06:07
Copy link
Contributor

github-actions bot commented Jan 31, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 3, 2025
@korniltsev korniltsev merged commit 0ebef89 into main Feb 5, 2025
32 checks passed
@korniltsev korniltsev deleted the ebpf_go_table_fallback branch February 5, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants