mixin: Add SR to remote_write dashboard #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
force-pushed
the
thampiotr/add-sr-to-remote-write-dash
branch
from
7c9b8bd to
57bab61
Compare
thampiotr
force-pushed
the
thampiotr/add-sr-to-remote-write-dash
branch
from
57bab61 to
76d8fed
Compare
mattdurham
approved these changes
Jun 21, 2024
thampiotr
commented
Jun 21, 2024
| # jsonnet files, reporting that the the Alloy dashboard folder "cannot be | ||
| # found" after creating it. | ||
| RUN go install github.com/grafana/grizzly/cmd/[email protected] | ||
| RUN go install github.com/grafana/grizzly/cmd/[email protected] |
There was a problem hiding this comment.
Will need to bump it once we land grafana/grizzly#458 upstream.
Comment on lines
+32
to
+36
| + g.dashboard.withTagsMixin($._config.dashboardTag) | ||
| + g.dashboard.withUid(std.md5(dashboardName)), | ||
| }, | ||
| }, | ||
| 'alloy-logs.json': alloyLogs.dashboards.logs, | ||
| [dashboardName]: alloyLogs.dashboards.logs, |
There was a problem hiding this comment.
Without these changes, grr will not be able to push the dashboards.
| ]) | ||
| ), | ||
|
|
||
| // Write latency |
There was a problem hiding this comment.
This is just moved from below. I like SR & latency to be the topline as they're main objectives.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist