Build plugin #57
Merged
Build plugin #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good now; there is unfortunately no way to test the publish to gcom step without merging it, so we may need to do a few small patches before it becomes fully end to end. |
annanay25
approved these changes
Jul 3, 2024
|
@annanay25 Wasn't sure they'd ever merge that PR, decided to copy all the code over here, should be just fine (and a lot easier to maintain over time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently waiting on this pr:
grafana/plugin-actions#28
And the github action here should be changed to reference the grafana-maintained github action instead of referencing the branch from my PR. (In the past I have not done this and this has created technical debt over in grafana-llm-app).
Provided that is done, the release workflow from this action would be:
Steps 2. and 3. can be rolled into automation if necessary, but we don't actually need to do this to run the plugin in dev environments; we can simply use the github release.