Display multiple panels per section #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were overwriting the section each time we came across a new metric within the section. Instead, append the new panel. Appending to a nil slice will naturally create a new slice so this is safe to do.
annanay25
reviewed
Nov 20, 2024
| @@ -348,7 +348,7 @@ func transformMetricsData(results []Result) GetModelMetricsResponse { | |||
| panels = append(panels, newPanel) | |||
| } | |||
|
|
|||
| response.Sections[sectionName] = panels | |||
| response.Sections[sectionName] = append(response.Sections[sectionName], panels...) | |||
There was a problem hiding this comment.
It's a little confusing to have the metric namespace as part of the name, maybe we can split that out into a separate field? But also that can be handled in another issue
There was a problem hiding this comment.
Yeah, that is way too big of a change to want to do as part of this PR. That would probably change the entire log signature and probably request format too, not sure if that is something we want.
| @@ -348,7 +348,7 @@ func transformMetricsData(results []Result) GetModelMetricsResponse { | |||
| panels = append(panels, newPanel) | |||
| } | |||
|
|
|||
| response.Sections[sectionName] = panels | |||
| response.Sections[sectionName] = append(response.Sections[sectionName], panels...) | |||
There was a problem hiding this comment.
Can we add a test for this?
There was a problem hiding this comment.
Updated a test to catch this case as well!
This test fails before the fix to putting groups together to catch any regressions. In addition, upgrade the version of godeltaprof being used in order to allow tests to be ran on a mac.
This both fixes an occassional failing test and will render the page in a deterministic way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were overwriting the section each time we came across a new metric within the section. Instead, append the new panel. Appending to a nil slice will naturally create a new slice so this is safe to do.