Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes very annoying error #116

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fixes very annoying error #116

merged 1 commit into from
Nov 14, 2024

Conversation

SandersAaronD
Copy link
Collaborator

No description provided.

csmarchbanks
csmarchbanks approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, rstrip might be slightly more appropriate, but starting with a / is not valid anyway.

@SandersAaronD SandersAaronD merged commit c53eb3d into main Nov 14, 2024
4 checks passed
@SandersAaronD SandersAaronD deleted the sandersaarond/strip-trailing-slash branch November 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandersAaronD @csmarchbanks