Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Plexus @Component annotations are removed #1398

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Sep 5, 2024

This PR removes the deprecated @Component annotations from the Quarkus extension and Maven Convention Develocity extension sample. They have been replaced with a dedicated file at src/main/resources/META-INF/plexus/components.xml instead.

@erichaagdev erichaagdev requested review from etiennestuder and a team September 5, 2024 18:20
@erichaagdev erichaagdev self-assigned this Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
verification_maven-[object Object] wrapper:wrapper 3.9.9 Build Scan NOT_PUBLISHED
verification_maven-[object Object] clean verify 3.6.3 Build Scan PUBLISHED
Generated by gradle/develocity-actions

Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichaagdev erichaagdev force-pushed the erichaagdev/remove-plexus-annotations branch from 5d7e8c1 to a8656d3 Compare September 9, 2024 15:39
@erichaagdev erichaagdev force-pushed the erichaagdev/remove-plexus-annotations branch from a8656d3 to 5bae80f Compare September 19, 2024 14:38
@erichaagdev
Copy link
Member Author

@etiennestuder after having a shift in priorities, this is ready for review once more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants