Async [un]subscribes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A full sync is only necessary after a device is added to a sync group. Each subscribe / unsubscribe is propagated to the whole sync group by the subscribe() / unsubscribe() methods directly, without the use of signals
|
Subscription API tests currently fail because there is no worker that processes the tasks. A celery worker might need to be run for processing tasks (see RentMethod/django-celery-testworker and RentMethod/django-celery-testworker#4). |
stefankoegl
force-pushed
the
subscribe-task
branch
from
006677c
to
c37a38a
Compare
|
Fixed by keeping API actions synchronous, and making only subscriptions triggered via web async. |
|
TODO: make the device (subscriptions? podcast?) UI reload until all pending subscriptions are complete. |
stefankoegl
force-pushed
the
master
branch
2 times, most recently
from
8ae746c
to
dde0f07
Compare
stefankoegl
force-pushed
the
master
branch
2 times, most recently
from
80cbe30
to
95b3360
Compare
|
Travis CI pytest passed. Merged into master. We could add functionality on front-end in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribe to / unsubscribe from podcasts in Celery tasks.