-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to customize Album names by introducing template as new option for Album name. #431
Conversation
increase test coverage of album.go to 94%
This is very basic and should be replaced with EXIF data or video metadata. However, it is a pretty involved change and will be submitted as a separate pull request after this code is landed.
and add abelity to wrap function argument in quotes ''
This change adds "template" to the list of valid album name formats and increases the complexity of the config validation. It looks like it was an intention to keep the config validation simple, but considering how complex the template itself is, I think the app should provide more information about what is exactly wrong with the template so the user can correct it.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 65.25% 72.03% +6.77%
==========================================
Files 22 22
Lines 947 1173 +226
==========================================
+ Hits 618 845 +227
Misses 305 305
+ Partials 24 23 -1 ☔ View full report in Codecov by Sentry. |
- incressing test coverage for alubm.go - split parser functions to make it bit more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing to this humble project with a feature that had been in the backlog for so long. I think it is something that some people were waiting for.
I have reviewed the code and it looks very good. Good test coverage and very readable code. Thanks for the effort in implementing the feature and trying to keep the code consistent.
I have made some comments, mostly typos. Once you review them ping me and I'll do a merge as well as a new release of the CLI.
Once again, thanks!
Happy to help. I use the project and really have fun working on it. Hopefully will have time to work on it more! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done and thanks for addressing all the comment 🙇🏼
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
resolves #150
resolves #157
Does this pull request add new dependencies?
Add the possibility to customize Album names by introducing template as new option for Album name.
A small parser has been implemented to support:
What to highlight some difference from proposed spec in #150.
What to highlight some other decision I made
What else do we need to know?