Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the option to bind the HTTP server to addresses other than local #426

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

WACKYprog
Copy link
Contributor

…n local ones.

What issue type does this pull request address? (keep at least one, remove the others)

/kind feature

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #
n/a

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)

Yes, it adds the ability to bind the authentication server to an IP other than the local host.

I use this tool on my Synology storage device, and the recommended authentication method with curl was really time-consuming and hard to understand without knowledge about OAuth. I hope this simplifies it a bit more.

I assume this is a pretty common use case, but I may be wrong. If you feel this is not the case, feel free to reject it.

Does this pull request add new dependencies?

No

What else do we need to know?

Here's the corrected sentence:

I unified how defaults are handled for the auth use case and took advantage of build in default handling.

@WACKYprog WACKYprog changed the title Introducing the option to bind the HTTP server to addresses other tha… Introducing the option to bind the HTTP server to addresses other than local Jan 4, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f480aea) 65.25% compared to head (a4622f6) 65.25%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files          22       22           
  Lines         947      947           
=======================================
  Hits          618      618           
  Misses        305      305           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pacoorozco
Copy link
Member

Hi @WACKYprog

Yes, I truly believe it could be a common use case. Back in the days I didn't take into consideration running this CLI headless, because the OAuth flow is difficult to complete wo/ a browser. But in the last versions, I've been adding more and more changes to make it work. This one was out of my mind, and It really helps.

Thanks a lot!

@pacoorozco pacoorozco merged commit 04afe08 into gphotosuploader:main Jan 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants