Introducing the option to bind the HTTP server to addresses other than local #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n local ones.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What is this pull request for? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves #
n/a
Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, it adds the ability to bind the authentication server to an IP other than the local host.
I use this tool on my Synology storage device, and the recommended authentication method with curl was really time-consuming and hard to understand without knowledge about OAuth. I hope this simplifies it a bit more.
I assume this is a pretty common use case, but I may be wrong. If you feel this is not the case, feel free to reject it.
Does this pull request add new dependencies?
No
What else do we need to know?
Here's the corrected sentence:
I unified how defaults are handled for the auth use case and took advantage of build in default handling.