Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammend a previous command renaming. Command is gphotos-uploader-cli #388

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

pacoorozco
Copy link
Member

Signed-off-by: pacoorozco [email protected]

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
In a previous PR we renamed the CLI to gphotos-cli, but this is causing confusion between the repository name and the CLI.

In this PR, we rename it again to gphotos-uploader-cli.

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, it will change the name of the command: gphotos-uploader-cli. The old name was not released and the documentation was still using to gphotos-uploader-cli

Does this pull request add new dependencies?

What else do we need to know?

@pacoorozco pacoorozco added this to the v4 milestone Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #388 (c24fa45) into 4.x (28b8f02) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              4.x     #388   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files          22       22           
  Lines         880      880           
=======================================
  Hits          587      587           
  Misses        270      270           
  Partials       23       23           
Files Coverage Δ
internal/cli/cli.go 100.00% <100.00%> (ø)
version/version.go 75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pacoorozco pacoorozco merged commit 5b86f0c into 4.x Oct 21, 2023
7 checks passed
@pacoorozco pacoorozco deleted the ammend-command-rename-to-gphotos-cli branch October 21, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant