avoid double free

gotray · Nov 3, 2024 · a005c44 · a005c44
1 parent 5e1a79e
commit a005c44
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/object.go b/object.go
@@ -52,12 +52,12 @@ func (obj Object) object() Object {
 
 func newObject(obj *PyObject) Object {
 	if obj == nil {
-		C.PyErr_Print()
 		return Object{}
 	}
 	o := &pyObject{obj: obj}
 	p := Object{o}
 	runtime.SetFinalizer(o, func(o *pyObject) {
+		// TODO: need better auto-release mechanism
 		// C.Py_DecRef(o.obj)
 	})
 	return p

diff --git a/python.go b/python.go
@@ -38,6 +38,7 @@ func CompileString(code, filename string, start InputType) Object {
 	ccode := AllocCStr(code)
 	cfilename := AllocCStr(filename)
 	o := C.Py_CompileString(ccode, cfilename, C.int(start))
+	// TODO: check why double free
 	C.free(unsafe.Pointer(ccode))
 	C.free(unsafe.Pointer(cfilename))
 	return newObject(o)
@@ -82,6 +83,9 @@ func Nil() Object {
 func RunString(code string) error {
 	// Get __main__ module dict for executing code
 	main := MainModule()
+	if main.Nil() {
+		return fmt.Errorf("failed to get __main__ module")
+	}
 	dict := main.Dict()
 
 	// Run the code string