Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate): fixes check for test.failfast flag as this is a gotest… #448

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

aldiesel
Copy link

@aldiesel aldiesel commented Nov 2, 2024

Our pipeline would sometimes pass without checking all tests as we had reruns and fail fast enabled.

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I believe both failfast and test.failfast are valid flag names for go test. Instead of replacing the failfast check, let's add a second check for the other flag name.

cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dnephin dnephin merged commit 31f5275 into gotestyourself:main Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants