fix: cambio formato mensaje de ayuda issue #2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Pozo <[email protected]>
| @@ -36,7 +36,6 @@ func init() { | |||
| // main | |||
| // Obtiene el comando a ejecutar desde la línea de comandos y lo invoca | |||
| func main() { | |||
| fmt.Printf("%s Version %s Build with Go %v at %v\n", provider.GetContainer().Config().APPName, BinVersion, BuildGoVersion, BuildTime) | |||
There was a problem hiding this comment.
¿Por que retirar este snippet? Es la base d ela feature para mostrar metadata de la app al momento de ejecutarla. Quizás explicarlo mejor en vez de removerlo
There was a problem hiding this comment.
Claro, pero cuando no hiciste el build, y estas corriendo la app, esa data no la tenes. Por eso es que lo cambie de lugar, no lo removi. Me parece que es data importante mas que nada cuando estas corriendo la API en produccion.
Queda raro, por encima del mensaje de ayuda, si no habria que ver de incorporar esa data en la ayuda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.